Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding check to make sure Help Tips exist before making a help tour for a portlet #1011

Merged
merged 2 commits into from
Aug 28, 2019
Merged

adding check to make sure Help Tips exist before making a help tour for a portlet #1011

merged 2 commits into from
Aug 28, 2019

Conversation

eiffel777
Copy link
Contributor

This PR adds a check in Portlet.js to make sure Help Tips exist before making a help tour for a portlet

Tests performed

Tested in XSEDE and XDMoD dockers

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@eiffel777 eiffel777 added bug Bugfixes Category:User Dashboard Screen shown after user login labels Aug 26, 2019
@eiffel777 eiffel777 added this to the 8.5.0 milestone Aug 26, 2019
@eiffel777 eiffel777 self-assigned this Aug 26, 2019
@eiffel777 eiffel777 merged commit 8f37ff1 into ubccr:xdmod8.5 Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpwhite4 jpwhite4 jpwhite4 approved these changes

Assignees

@eiffel777 eiffel777

Labels
bug Bugfixes Category:User Dashboard Screen shown after user login
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@eiffel777 @jpwhite4